feat(testing): add assert response json assertions #1433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treggats
force-pushed
the
feature/add-assertJsonByKeys-assertion
branch
4 times, most recently
from
6f7c40f to
5939045
Compare
Treggats
commented
Jul 25, 2025
Treggats
force-pushed
the
feature/add-assertJsonByKeys-assertion
branch
3 times, most recently
from
97b232f to
ddb903e
Compare
innocenzi
previously requested changes
Jul 28, 2025
Treggats
force-pushed
the
feature/add-assertJsonByKeys-assertion
branch
2 times, most recently
from
17af070 to
d7293d3
Compare
Treggats
force-pushed
the
feature/add-assertJsonByKeys-assertion
branch
from
a288e20 to
785d5fe
Compare
brendt
requested changes
Jul 29, 2025
Member
|
I like it! A couple of small remarks to solve, but this will be really useful |
Treggats
force-pushed
the
feature/add-assertJsonByKeys-assertion
branch
from
785d5fe to
239c918
Compare
There was a `tests/Fixtures/Requests` directory, made sense to move the Request classes there.
Treggats
force-pushed
the
feature/add-assertJsonByKeys-assertion
branch
3 times, most recently
from
d07fd96 to
d7fe656
Compare
Signed-off-by: Tonko Mulder <[email protected]>
Treggats
force-pushed
the
feature/add-assertJsonByKeys-assertion
branch
from
d7fe656 to
18e6f3d
Compare
brendt
approved these changes
Jul 30, 2025
Member
|
Thanks! Nice PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1427
Main changes
TestResponseHelper;assertJson()assertJsonByKeys()assertHasJsonValidationError()Secondary changes